[PATCH] Downgrade the error about nested name specifiers when building with Microsoft extensions

Kim Gräsman kim.grasman at gmail.com
Mon Jun 30 13:36:36 PDT 2014


On Mon, Jun 30, 2014 at 10:24 PM, Ehsan Akhgari <ehsan.akhgari at gmail.com> wrote:
> On Mon, Jun 30, 2014 at 1:11 PM, Alp Toker <alp at nuanti.com> wrote:
>>
>> The counterargument is that accepting MSVC quirks makes it easier to
>> produce valid intermediate ASTs so that consumers can fix their source code
>> automatically with refactoring instead of manually.
>>
>> That said, if the extension syntax doesn't appear much in the wild then
>> fixing by hand is low-effort so it doesn't matter a great deal either way.
>
> FWIW this is the Mozilla fix that I made:
> https://hg.mozilla.org/mozilla-central/rev/db977537acef  It was pretty
> simple.  :-)

Just as a datapoint, we had this pretty widespread in our codebase,
but cleaned it up when we first built with Clang.

I think both MSVC2012 and GCC 4.6.1 accepted the syntax, not sure
about the current situation.

- Kim



More information about the cfe-commits mailing list