r211738 - Remove REQUIRES lines from portable tests

[Alp Toker]

So, there are still 138 tests with REQUIRES *-registered-target lines 
under test/CodeGen* and more in other test directories.

About half of these are actually portable and shouldn't have been 
suppressed.

The problem is widespread enough that I think we need to be more 
proactive to help identify bad suppressions during testing and review:

1) The feature name *-registered-target is ambiguous. Should be renamed 
to something clearer like *-assembler / *-backend / *-codegen.

2) lit should have a mode to translate REQUIRES into !XFAIL. That's how 
I identified these incorrectly suppressed tests that were in fact 
working just fine.

Alp.


On 26/06/2014 20:39, Rafael Espíndola wrote:
> thanks!
>
> On 25 June 2014 18:46, Alp Toker <alp at nuanti.com> wrote:
>> Author: alp
>> Date: Wed Jun 25 17:46:44 2014
>> New Revision: 211738
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=211738&view=rev
>> Log:
>> Remove REQUIRES lines from portable tests
>>
>> These tests are target-independent and shouldn't ever be suppressed.
>>
>> Modified:
>>      cfe/trunk/test/Driver/freebsd.c
>>      cfe/trunk/test/Driver/hexagon-toolchain-elf.c
>>      cfe/trunk/test/Driver/hexagon-toolchain.c
>>      cfe/trunk/test/Modules/compiler_builtins_arm.m
>>
>> Modified: cfe/trunk/test/Driver/freebsd.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/freebsd.c?rev=211738&r1=211737&r2=211738&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Driver/freebsd.c (original)
>> +++ cfe/trunk/test/Driver/freebsd.c Wed Jun 25 17:46:44 2014
>> @@ -1,4 +1,3 @@
>> -// REQUIRES: powerpc-registered-target,mips-registered-target
>>   // RUN: %clang -no-canonical-prefixes \
>>   // RUN:   -target powerpc-pc-freebsd8 %s    \
>>   // RUN:   --sysroot=%S/Inputs/basic_freebsd_tree -### 2>&1 \
>>
>> Modified: cfe/trunk/test/Driver/hexagon-toolchain-elf.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/hexagon-toolchain-elf.c?rev=211738&r1=211737&r2=211738&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Driver/hexagon-toolchain-elf.c (original)
>> +++ cfe/trunk/test/Driver/hexagon-toolchain-elf.c Wed Jun 25 17:46:44 2014
>> @@ -1,5 +1,3 @@
>> -// REQUIRES: hexagon-registered-target
>> -
>>   // -----------------------------------------------------------------------------
>>   // Test standard include paths
>>   // -----------------------------------------------------------------------------
>>
>> Modified: cfe/trunk/test/Driver/hexagon-toolchain.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/hexagon-toolchain.c?rev=211738&r1=211737&r2=211738&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Driver/hexagon-toolchain.c (original)
>> +++ cfe/trunk/test/Driver/hexagon-toolchain.c Wed Jun 25 17:46:44 2014
>> @@ -1,5 +1,3 @@
>> -// REQUIRES: hexagon-registered-target
>> -
>>   // -----------------------------------------------------------------------------
>>   // Test standard include paths
>>   // -----------------------------------------------------------------------------
>>
>> Modified: cfe/trunk/test/Modules/compiler_builtins_arm.m
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/compiler_builtins_arm.m?rev=211738&r1=211737&r2=211738&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Modules/compiler_builtins_arm.m (original)
>> +++ cfe/trunk/test/Modules/compiler_builtins_arm.m Wed Jun 25 17:46:44 2014
>> @@ -1,6 +1,5 @@
>>   // RUN: rm -rf %t
>>   // RUN: %clang_cc1 -fsyntax-only -triple thumbv7-none-linux-gnueabihf -target-abi aapcs -target-cpu cortex-a8 -mfloat-abi hard -std=c99 -fmodules -fmodules-cache-path=%t -D__need_wint_t %s -verify
>>   // expected-no-diagnostics
>> -// REQUIRES: arm-registered-target
>>
>>   @import _Builtin_intrinsics.arm.neon;
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-- 
http://www.nuanti.com
the browser experts