r207829 - CodeGen: rename __builtin_arm_sevl to __sevl

[Saleem Abdulrasool]

On Friday, June 27, 2014, Renato Golin <renato.golin at linaro.org> wrote:

> Hi Yi,
>
> Sorry for breaking that, I agree the header is a better solution.
> Saleem, does the header solve your problem on Windows?


Unfortunately, not.  They are MSVC intrinsics and the SDK uses them without
the inclusion of any header.  These must be provided with the prescribed
name implicitly as a result.


> cheers,
> --renato
>
> On 27 June 2014 15:55, Yi Kong <kongy.dev at gmail.com <javascript:;>> wrote:
> > Patch attached to rename hints intrinsic back to their conventional
> naming.
> >
> > Cheers,
> > Yi
> >
> > On 23 June 2014 23:00, Yi Kong <kongy.dev at gmail.com <javascript:;>>
> wrote:
> >> On 23 June 2014 18:09, Saleem Abdulrasool <abdulras at fb.com
> <javascript:;>> wrote:
> >>>
> >>> On Jun 23, 2014, at 9:33 AM, Yi Kong <kongy.dev at gmail.com
> <javascript:;>> wrote:
> >>>
> >>>> Saleem Abdulrasool <compnerd at ...> writes:
> >>>>
> >>>>>
> >>>>> Author: compnerd
> >>>>> Date: Fri May  2 01:53:57 2014
> >>>>> New Revision: 207829
> >>>>>
> >>>>> URL: http://llvm.org/viewvc/llvm-project?rev=207829&view=rev
> >>>>> Log:
> >>>>> CodeGen: rename __builtin_arm_sevl to __sevl
> >>>>>
> >>>>> ACLE adds the __sevl() extension.  Rename the hint from a custom
> name to
> >>>> the
> >>>>> ACLE specified name.
> >>>>>
> >>>>
> >>>> The renaming breaks the naming convention for Clang built-in
> intrinsics.
> >>>> Every target-specific intrinsic should begin with __builtin_ArchName.
> >>>>
> >>>> __sevl should be defined to __builtin_arm_sevl in arm_acle.h file.
> >>>
> >>> Sorry, I guess that I should have added more context into the commit
> message.  This was discussed on IRC between Tim, Joey, Renato, and I.  The
> ACLE defines the spelling to be __sevl, and since the change wasn’t there
> for very long, we decided that we would use the proper spelling.  __sevl is
> already in a reserved namespace for the system, and providing an official
> extension symbol in that namespace is fine.
> >>
> >> ACLE defines the spelling in the arm_acle.h header file instead of the
> >> compiler intrinsics.
> >>
> >> Since I'm currently working on the ACLE header file, I think it would
> >> be best to stick to the conventional naming and map __sevl to
> >> __builtin_arm_sevl in arm_acle.h.
> >>
> >> -Yi
> >>
> >>>> _______________________________________________
> >>>> cfe-commits mailing list
> >>>> cfe-commits at cs.uiuc.edu <javascript:;>
> >>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >>>
> >>> --
> >>> Saleem Abdulrasool
> >>> abdulras (at) fb (dot) com
> >>>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu <javascript:;>
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>


-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140627/07a03904/attachment.html>