r211901 - This fixes libclang to cope with the now compile-time multithreaded
Chandler Carruth
chandlerc at gmail.com
Fri Jun 27 08:14:40 PDT 2014
Author: chandlerc
Date: Fri Jun 27 10:14:39 2014
New Revision: 211901
URL: http://llvm.org/viewvc/llvm-project?rev=211901&view=rev
Log:
This fixes libclang to cope with the now compile-time multithreaded
selection re-enabled in r211900 in LLVM.
The approach (unlike r211121) doesn't rely on std::mutex or
std::call_once to avoid breaknig cygwin bots.
Modified:
cfe/trunk/tools/libclang/CIndex.cpp
Modified: cfe/trunk/tools/libclang/CIndex.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CIndex.cpp?rev=211901&r1=211900&r2=211901&view=diff
==============================================================================
--- cfe/trunk/tools/libclang/CIndex.cpp (original)
+++ cfe/trunk/tools/libclang/CIndex.cpp Fri Jun 27 10:14:39 2014
@@ -43,6 +43,7 @@
#include "llvm/Support/Compiler.h"
#include "llvm/Support/CrashRecoveryContext.h"
#include "llvm/Support/Format.h"
+#include "llvm/Support/ManagedStatic.h"
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/Mutex.h"
#include "llvm/Support/Program.h"
@@ -2591,9 +2592,6 @@ buildPieces(unsigned NameFlags, bool IsM
// Misc. API hooks.
//===----------------------------------------------------------------------===//
-static llvm::sys::Mutex EnableMultithreadingMutex;
-static bool EnabledMultithreading;
-
static void fatal_error_handler(void *user_data, const std::string& reason,
bool gen_crash_diag) {
// Write the result out to stderr avoiding errs() because raw_ostreams can
@@ -2610,15 +2608,7 @@ CXIndex clang_createIndex(int excludeDec
if (!getenv("LIBCLANG_DISABLE_CRASH_RECOVERY"))
llvm::CrashRecoveryContext::Enable();
- // Enable support for multithreading in LLVM.
- {
- llvm::sys::ScopedLock L(EnableMultithreadingMutex);
- if (!EnabledMultithreading) {
- llvm::install_fatal_error_handler(fatal_error_handler, nullptr);
- llvm::llvm_start_multithreaded();
- EnabledMultithreading = true;
- }
- }
+ llvm::install_fatal_error_handler(fatal_error_handler, nullptr);
CIndexer *CIdxr = new CIndexer();
if (excludeDeclarationsFromPCH)
@@ -6999,10 +6989,12 @@ Logger &cxindex::Logger::operator<<(cons
return *this;
}
+static llvm::ManagedStatic<llvm::sys::Mutex> LoggingMutex;
+
cxindex::Logger::~Logger() {
LogOS.flush();
- llvm::sys::ScopedLock L(EnableMultithreadingMutex);
+ llvm::sys::ScopedLock L(*LoggingMutex);
static llvm::TimeRecord sBeginTR = llvm::TimeRecord::getCurrentTime();
More information about the cfe-commits
mailing list