[clang-tools-extra] r211702 - Add a check to flag the usage of C-style casts (Google Style).
Alexander Kornienko
alexfh at google.com
Wed Jun 25 07:52:44 PDT 2014
Author: alexfh
Date: Wed Jun 25 09:52:44 2014
New Revision: 211702
URL: http://llvm.org/viewvc/llvm-project?rev=211702&view=rev
Log:
Add a check to flag the usage of C-style casts (Google Style).
Summary:
Add a check to flag the usage of C-style casts, as per Google Style
Guide:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Casting#Casting
Reviewers: djasper
Reviewed By: djasper
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D4189
Added:
clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.cpp
clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.h
clang-tools-extra/trunk/test/clang-tidy/c-style-casts.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt
clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp
Modified: clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt?rev=211702&r1=211701&r2=211702&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt (original)
+++ clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt Wed Jun 25 09:52:44 2014
@@ -1,6 +1,7 @@
set(LLVM_LINK_COMPONENTS support)
add_clang_library(clangTidyGoogleModule
+ CStyleCastsCheck.cpp
ExplicitConstructorCheck.cpp
GoogleTidyModule.cpp
Added: clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.cpp?rev=211702&view=auto
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.cpp (added)
+++ clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.cpp Wed Jun 25 09:52:44 2014
@@ -0,0 +1,52 @@
+//===--- CStyleCastsCheck.cpp - clang-tidy ----------------------*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#include "CStyleCastsCheck.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/ASTMatchers/ASTMatchers.h"
+
+using namespace clang::ast_matchers;
+
+namespace clang {
+namespace tidy {
+namespace readability {
+
+void CStyleCastsCheck::registerMatchers(ast_matchers::MatchFinder *Finder) {
+ Finder->addMatcher(
+ cStyleCastExpr(
+ // Filter out (EnumType)IntegerLiteral construct, which is generated
+ // for non-type template arguments of enum types.
+ // FIXME: Remove this once this is fixed in the AST.
+ unless(allOf(hasDestinationType(hasDeclaration(enumDecl())),
+ hasSourceExpression(integerLiteral())))).bind("cast"),
+ this);
+}
+
+void CStyleCastsCheck::check(const MatchFinder::MatchResult &Result) {
+ const auto *CastExpr = Result.Nodes.getNodeAs<CStyleCastExpr>("cast");
+
+ // Ignore casts in macros for now.
+ if (CastExpr->getLocStart().isMacroID())
+ return;
+
+ // Casting to void is an idiomatic way to mute "unused variable" and similar
+ // warnings.
+ if (CastExpr->getTypeAsWritten()->isVoidType())
+ return;
+
+ diag(CastExpr->getLocStart(), "C-style casts are discouraged. Use "
+ "static_cast/const_cast/reinterpret_cast "
+ "instead.");
+ // FIXME: Suggest appropriate C++ cast. See [expr.cast] for cast notation
+ // semantics.
+}
+
+} // namespace readability
+} // namespace tidy
+} // namespace clang
Added: clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.h
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.h?rev=211702&view=auto
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.h (added)
+++ clang-tools-extra/trunk/clang-tidy/google/CStyleCastsCheck.h Wed Jun 25 09:52:44 2014
@@ -0,0 +1,33 @@
+//===--- CStyleCastsCheck.h - clang-tidy ------------------------*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_C_STYLE_CASTS_CHECK_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_C_STYLE_CASTS_CHECK_H
+
+#include "../ClangTidy.h"
+
+namespace clang {
+namespace tidy {
+namespace readability {
+
+/// \brief Finds usages of C-style casts.
+///
+/// http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Casting#Casting
+/// Corresponding cpplint.py check name: 'readability/casting'.
+class CStyleCastsCheck : public ClangTidyCheck {
+public:
+ void registerMatchers(ast_matchers::MatchFinder *Finder) override;
+ void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+};
+
+} // namespace readability
+} // namespace tidy
+} // namespace clang
+
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_C_STYLE_CASTS_CHECK_H
Modified: clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp?rev=211702&r1=211701&r2=211702&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/google/GoogleTidyModule.cpp Wed Jun 25 09:52:44 2014
@@ -10,6 +10,7 @@
#include "../ClangTidy.h"
#include "../ClangTidyModule.h"
#include "../ClangTidyModuleRegistry.h"
+#include "CStyleCastsCheck.h"
#include "ExplicitConstructorCheck.h"
using namespace clang::ast_matchers;
@@ -23,6 +24,9 @@ public:
CheckFactories.addCheckFactory(
"google-explicit-constructor",
new ClangTidyCheckFactory<ExplicitConstructorCheck>());
+ CheckFactories.addCheckFactory(
+ "google-readability-casting",
+ new ClangTidyCheckFactory<readability::CStyleCastsCheck>());
}
};
Added: clang-tools-extra/trunk/test/clang-tidy/c-style-casts.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/c-style-casts.cpp?rev=211702&view=auto
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/c-style-casts.cpp (added)
+++ clang-tools-extra/trunk/test/clang-tidy/c-style-casts.cpp Wed Jun 25 09:52:44 2014
@@ -0,0 +1,24 @@
+// RUN: clang-tidy -checks=-*,google-readability-casting %s -- | FileCheck %s
+
+// CHECK-NOT: warning:
+
+bool g() { return false; }
+
+void f(int a, double b) {
+ int b1 = (int)b;
+ // CHECK: :[[@LINE-1]]:12: warning: C-style casts are discouraged. Use static_cast{{.*}}
+
+ // CHECK-NOT: warning:
+ int b2 = int(b);
+ int b3 = static_cast<double>(b);
+ int b4 = b;
+ double aa = a;
+ (void)b2;
+ return (void)g();
+}
+
+// CHECK-NOT: warning:
+enum E { E1 = 1 };
+template <E e>
+struct A { static const E ee = e; };
+struct B : public A<E1> {};
More information about the cfe-commits
mailing list