[PATCH] Add clang-tidy-diff.py script to run clang-tidy and display warnings on changed lines only.
Alexander Kornienko
alexfh at google.com
Wed Jun 25 07:17:32 PDT 2014
================
Comment at: clang-tidy/tool/clang-tidy-diff.py:34
@@ +33,3 @@
+import subprocess
+import StringIO
+import sys
----------------
Daniel Jasper wrote:
> Is StringIO used?
Removed unused imports.
================
Comment at: clang-tidy/tool/clang-tidy-diff.py:52
@@ +51,3 @@
+ parser.add_argument('-iregex', metavar='PATTERN', default=
+ r'.*\.(cpp|cc|c\+\+|cxx|c|cl|h|hpp|m|mm|inc|js|proto'
+ r'|protodevel)',
----------------
Daniel Jasper wrote:
> Are js, proto and protodevel useful here?
Not really. Removed.
================
Comment at: clang-tidy/tool/clang-tidy-diff.py:103
@@ +102,3 @@
+
+ # TODO: Corner cases.
+ line_filter_json = json.dumps(
----------------
Daniel Jasper wrote:
> s/TODO/FIXME/
>
> And maybe provide a bit of context as this doesn't really mean anything.
Removed the comment, what I meant there, is already handled.
http://reviews.llvm.org/D4288
More information about the cfe-commits
mailing list