[PATCH] Improve diagnostic message for misplaced square brackets

Richard Trieu rtrieu at google.com
Tue Jun 24 16:23:16 PDT 2014


Committed at r211641.

================
Comment at: lib/Parse/ParseDecl.cpp:5646-5649
@@ +5645,6 @@
+
+  // Nothing after the brackets has been parsed as part of the Declarator, so
+  // no correction is needed.
+  if (OldEndLoc == D.getLocEnd())
+    return;
+
----------------
Richard Smith wrote:
> This looks unreachable. If nothing after the brackets has been parsed, then there can't be an identifier, so we should have bailed out already. Remove?
Removed.

http://reviews.llvm.org/D2712






More information about the cfe-commits mailing list