[PATCH] Driver: enhance MSC version compatibility

Reid Kleckner rnk at google.com
Fri Jun 20 12:30:07 PDT 2014


================
Comment at: lib/Basic/Targets.cpp:582
@@ +581,3 @@
+    // Ideally, the -fmsc-version would take a period delimited component of the
+    // form MM.mm.bbbbb.pp (e.g. 17.00.60610.1).  Unfortunately, the current
+    // limitation of 32-bits prevents the encoding of Patch.  Assume that patch
----------------
Saleem Abdulrasool wrote:
> Reid Kleckner wrote:
> > I'm not crazy about -fmsc-version=MMmmmbbbbb.  How about -fmsc-version either takes a non-full number, or it takes a dot-separated number as described here?  We can skip the patch version for now, since that's too many bits.
> AFAICT, the value is a uint32_t.  How would the dot separated value be passed to it?  I would certainly prefer that.
Change this line in CompilerInvocation.cpp to parse the dot separated value:
  Opts.MSCVersion = getLastArgIntValue(Args, OPT_fmsc_version, 0, Diags);

http://reviews.llvm.org/D4233






More information about the cfe-commits mailing list