[PATCH] Warn on use of vector initializers in ARM BE mode

James Molloy James.Molloy at arm.com
Fri Jun 20 07:49:31 PDT 2014


Thanks!

Committed in r211362.

From: Alp Toker [mailto:alp at nuanti.com]
Sent: 20 June 2014 13:45
To: James Molloy; 'Renato Golin'
Cc: Tim Northover; Clang Commits
Subject: RE: [PATCH] Warn on use of vector initializers in ARM BE mode

Yes, I'm happy.

LGTM
On 20 June 2014 10:20:04 EEST, James Molloy <james.molloy at arm.com<mailto:james.molloy at arm.com>> wrote:

Thanks Renato!

Alp, are you happy too?

Cheers,

James

 -----Original Message-----
 From: Renato Golin [mailto:renato.golin at linaro.org]
 Sent: 19 June 2014 17:08
 To: James Molloy
 Cc: Tim Northover; Clang Commits
 Subject: Re: [PATCH] Warn on use of vector initializers in ARM BE mode

 LGTM

 On 19 June 2014 16:27, James Molloy <james.molloy at arm.com<mailto:james.molloy at arm.com>> wrote:

 Hi chaps,

 So I've edited the patch again, taking into account Alp's comments.

 The behaviour of the patch is that now, it will warn when encountering

 an initializer on a NEON type (not just any ext_vector) in big endian
 mode.

 I think the impact of this is now sufficiently small that there should

 be no complaints, and it could save users a lot of anguish.

 Cheers,

 James

 -----Original Message-----
 From: Tim Northover [mailto:t.p.northover at gmail.com]
 Sent: 19 June 2014 14:53
 To: Renato Golin
 Cc: James Molloy; Clang Commits
 Subject: Re: [PATCH] Warn on use of vector initializers in ARM BE mode

 Tim, do you have any use case for the lack of the

header, or is it
 just theoretical?

 Nah, it's purely theoretical. I don't really object to the patch
 either, so go ahead if people think it's a good idea.

 Cheers.

 Tim.




-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140620/37a00d34/attachment.html>


More information about the cfe-commits mailing list