Fix RecursiveASTVisitor to visit copy expressions of captured variables in blocks (ObjC++11)

Alp Toker alp at nuanti.com
Thu Jun 19 11:38:16 PDT 2014


On 19/06/2014 19:48, Mathieu Baudet wrote:
> Hi Alp,
>
> Have you had a chance to look at the last patch I sent?


Hi Mathieu,

I see you're exercising the edge cases, I had to do a double take on 
this one :-)

It looks fine to me.

Alp.



>
> -- Mathieu
>
> 2014-06-11 21:23 GMT-07:00 Mathieu Baudet <mathieu.baudet at gmail.com>:
>> Oups I thought I had tested but had not. Here is the real, and
>> hopefully final, patch.
>>
>> 2014-06-11 12:33 GMT-07:00 Mathieu Baudet <mathieu.baudet at gmail.com>:
>>> Hi Alp,
>>>
>>> Sure. Here is another patch using the new syntax.
>>>
>>> -- Mathieu
>>>
>>> 2014-06-07 11:46 GMT-07:00 Alp Toker <alp at nuanti.com>:
>>>> On 07/06/2014 03:44, Mathieu Baudet wrote:
>>>>> Hi,
>>>>>
>>>>> I found a corner case in ObjC++11 where the RecursiveASTVisitor could
>>>>> miss the body of a block.
>>>>>
>>>>> Please find the patch in attachment (unit test included).
>>>>
>>>> The approach looks OK but please simplify with for (const auto &I :
>>>> D->captures()).
>>>>
>>>> Alp.
>>>>
>>>>> -- Mathieu
>>>>
>>>> --
>>>> http://www.nuanti.com
>>>> the browser experts
>>>>

-- 
http://www.nuanti.com
the browser experts




More information about the cfe-commits mailing list