[PATCH] Add module flags metadata to record the settings for enum and wchar width

Renato Golin renato.golin at linaro.org
Thu Jun 19 09:57:38 PDT 2014


Even though we "assumed" that was true, we didn't have the attributes in place, if the default was different, say v4 from v7, than you'll get weird results. I'm just making sure this is intentional and clear.

But there's a second issue. This code will output the metadata on any architecture not just ARM, right? So, you'll get odd flags on IR where this has no meaning, and worse still, could be used in the future to mean something on a different architecture, which is not future proof.

I think a better approach is to *just* emit the metadata is the flag exists, and make the back-end work out what the defaults are on their own platforms and options.

http://reviews.llvm.org/D4212






More information about the cfe-commits mailing list