[PATCH] Warn on use of vector initializers in ARM BE mode

Renato Golin renato.golin at linaro.org
Thu Jun 19 09:07:32 PDT 2014


LGTM

On 19 June 2014 16:27, James Molloy <james.molloy at arm.com> wrote:
> Hi chaps,
>
> So I've edited the patch again, taking into account Alp's comments.
>
> The behaviour of the patch is that now, it will warn when encountering an initializer on a NEON type (not just any ext_vector) in big endian mode.
>
> I think the impact of this is now sufficiently small that there should be no complaints, and it could save users a lot of anguish.
>
> Cheers,
>
> James
>
>> -----Original Message-----
>> From: Tim Northover [mailto:t.p.northover at gmail.com]
>> Sent: 19 June 2014 14:53
>> To: Renato Golin
>> Cc: James Molloy; Clang Commits
>> Subject: Re: [PATCH] Warn on use of vector initializers in ARM BE mode
>>
>> > Tim, do you have any use case for the lack of the header, or is it
>> > just theoretical?
>>
>> Nah, it's purely theoretical. I don't really object to the patch
>> either, so go ahead if people think it's a good idea.
>>
>> Cheers.
>>
>> Tim.



More information about the cfe-commits mailing list