[PATCH] Fix clang-tidy delete of stack object

[Aaron Wishnick]

When I run clang-tidy on OS X 10.9.3, I immediately get this output:

clang-tidy(97903,0x7fff782fb310) malloc: *** error for object
0x7fff5fbfecd0: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug

This occurs inside the destructor of ClangTidyDiagnosticConsumer. Here's my
callstack:

#4 0x000000010058e3e2 in ~ClangTidyDiagnosticConsumer at
/Users/awishnick/clang-tidy/llvm/tools/clang/tools/extra/clang-tidy/ClangTidyDiagnosticConsumer.h:190
#5 0x0000000100656a73 in
std::__1::default_delete<clang::DiagnosticConsumer>::operator()(clang::DiagnosticConsumer*)
const [inlined] at
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:2426
#6 0x0000000100656a4b in std::__1::unique_ptr<clang::DiagnosticConsumer,
std::__1::default_delete<clang::DiagnosticConsumer>
>::reset(clang::DiagnosticConsumer*) [inlined] at
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:2625
#7 0x00000001006569f5 in ~unique_ptr [inlined] at
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:2593
#8 0x00000001006569f5 in ~unique_ptr [inlined] at
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/c++/v1/memory:2593
#9 0x00000001006569f5 in ~ChainedDiagnosticConsumer at
/Users/awishnick/clang-tidy/llvm/tools/clang/include/clang/Frontend/ChainedDiagnosticConsumer.h:23
#10 0x0000000100656595 in ~ChainedDiagnosticConsumer at
/Users/awishnick/clang-tidy/llvm/tools/clang/include/clang/Frontend/ChainedDiagnosticConsumer.h:23
#11 0x00000001006565b9 in ~ChainedDiagnosticConsumer at
/Users/awishnick/clang-tidy/llvm/tools/clang/include/clang/Frontend/ChainedDiagnosticConsumer.h:23
#12 0x00000001015eec84 in ~DiagnosticsEngine at
/Users/awishnick/clang-tidy/llvm/tools/clang/lib/Basic/Diagnostic.cpp:68
#13 0x00000001015eec35 in ~DiagnosticsEngine at
/Users/awishnick/clang-tidy/llvm/tools/clang/lib/Basic/Diagnostic.cpp:66
#14 0x00000001006bd3d3 in
llvm::RefCountedBase<clang::DiagnosticsEngine>::Release() const at
/Users/awishnick/clang-tidy/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:55
#15 0x00000001006bd325 in
llvm::IntrusiveRefCntPtrInfo<clang::DiagnosticsEngine>::release(clang::DiagnosticsEngine*)
at /Users/awishnick/clang-tidy/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:90
#16 0x00000001006bd2fd in
llvm::IntrusiveRefCntPtr<clang::DiagnosticsEngine>::release() at
/Users/awishnick/clang-tidy/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:199
#17 0x00000001006bd2c5 in ~IntrusiveRefCntPtr at
/Users/awishnick/clang-tidy/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:172
#18 0x00000001006bbe15 in ~IntrusiveRefCntPtr at
/Users/awishnick/clang-tidy/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:172
#19 0x000000010065cbc1 in ~CompilerInstance at
/Users/awishnick/clang-tidy/llvm/tools/clang/lib/Frontend/CompilerInstance.cpp:63
#20 0x000000010065c505 in ~CompilerInstance at
/Users/awishnick/clang-tidy/llvm/tools/clang/lib/Frontend/CompilerInstance.cpp:61
#21 0x00000001005d6474 in
clang::tooling::FrontendActionFactory::runInvocation(clang::CompilerInvocation*,
clang::FileManager*, clang::DiagnosticConsumer*) at
/Users/awishnick/clang-tidy/llvm/tools/clang/lib/Tooling/Tooling.cpp:270
#22 0x00000001005d614f in
clang::tooling::ToolInvocation::runInvocation(char const*,
clang::driver::Compilation*, clang::CompilerInvocation*) at
/Users/awishnick/clang-tidy/llvm/tools/clang/lib/Tooling/Tooling.cpp:243
#23 0x00000001005d5290 in clang::tooling::ToolInvocation::run() at
/Users/awishnick/clang-tidy/llvm/tools/clang/lib/Tooling/Tooling.cpp:229
#24 0x00000001005d7b29 in
clang::tooling::ClangTool::run(clang::tooling::ToolAction*) at
/Users/awishnick/clang-tidy/llvm/tools/clang/lib/Tooling/Tooling.cpp:360
#25 0x0000000100566cd2 in
clang::tidy::runClangTidy(clang::tidy::ClangTidyOptionsProvider*,
clang::tooling::CompilationDatabase const&,
llvm::ArrayRef<std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> > >,
std::__1::vector<clang::tidy::ClangTidyError,
std::__1::allocator<clang::tidy::ClangTidyError> >*) at
/Users/awishnick/clang-tidy/llvm/tools/clang/tools/extra/clang-tidy/ClangTidy.cpp:345
#26 0x0000000100002a96 in main at
/Users/awishnick/clang-tidy/llvm/tools/clang/tools/extra/clang-tidy/tool/ClangTidyMain.cpp:145

In short, it appears that ClangTool takes ownership of the diagnostic
consumer, but it's being allocated on the stack. My fix is to allocate it
on the heap instead. I've attached my patch. Please let me know if this
assessment is incorrect, or if you'd like me to go about this differently.

Thanks!
Aaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140619/e9751bbc/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-tidy.patch
Type: application/octet-stream
Size: 627 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140619/e9751bbc/attachment.obj>