[PATCH] Warn on use of vector initializers in ARM BE mode

[James Molloy]

Hi Tim, Alp,

Tim, you're right. However Alp I think has the solution - if we only fire when a NEON vector type is used, it restricts to only types that are defined in arm_neon.h.

Alp, I implemented both of your suggestions, and a new patch is attached.

Thanks for catching both of these!

James

> -----Original Message-----
> From: Tim Northover [mailto:t.p.northover at gmail.com]
> Sent: 19 June 2014 12:39
> To: James Molloy
> Cc: Alp Toker; Clang Commits
> Subject: Re: [PATCH] Warn on use of vector initializers in ARM BE mode
> 
> Hi James,
> 
> On 19 June 2014 11:13, James Molloy <james.molloy at arm.com> wrote:
> > Thanks for the comments. New patch attached, is it any better? I'm not
> sure
> > exactly what style we normally use for the diagnostics.
> 
> Doesn't this warning trigger even if arm_neon.h is nowhere to be
> found? That seems a bit broad, the GNU vector extensions are useful in
> their own right, and I'm not sure we should be effectively deprecating
> them on ARM.
> 
> Unfortunately, I've got no ideas on how to only give a message when
> it's relevant. I don't really do much on clang either.
> 
> Other than that, you need a Triple::aarch64 check too.
> 
> Cheers.
> 
> Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-The-ability-to-use-vector-initializer-lists-is-a-GNU.patch
Type: application/octet-stream
Size: 6223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140619/3756d110/attachment.obj>