[PATCH] Driver: generate file lists to pass through to linkers
Hans Wennborg
hans at chromium.org
Wed Jun 18 11:12:45 PDT 2014
On Tue, Jun 17, 2014 at 11:27 AM, Saleem Abdulrasool <abdulras at fb.com> wrote:
> ping
>
> http://reviews.llvm.org/D4104
I'm still not a fan of the complexity this adds to AddLinkerInputs:
careful logic to open and close numbered rsp files, etc., whereas the
usual work of this function is just to add some inputs to a vector.
Even if we can't push this response file stuff all the way down to
when we invoke subprocesses, I think that building the list of
arguments, and possibly putting some of them in a response file should
be separate things.
Are there really linkers that we care about that don't understand
response files, but accept these "file list files"?
- Hans
More information about the cfe-commits
mailing list