[PATCH] CodeGen: improve ms instrincics support
Saleem Abdulrasool
abdulras at fb.com
Wed Jun 18 10:47:31 PDT 2014
================
Comment at: lib/Headers/Intrin.h:227
@@ -226,3 +226,3 @@
static __inline__
-long __cdecl _InterlockedExchange(long volatile *_Target, long _Value);
static __inline__
----------------
Warren Hunt wrote:
> I don't see why it was necessary to get rid of __cdecl. Also, Now that the definition is gone it shouldn't be static __inline__ anymore.
Getting rid of `__cdecl` is actually quite important since this header is not x86 specific. ARM does not honour `__cdecl`, and thus generates a warning.
Good catch about the static `__inline__`. I've become too accustomed to the LLVM style and didnt notice that.
http://reviews.llvm.org/D4182
More information about the cfe-commits
mailing list