[PATCH 5/8] Add simple way for a CorrectionCandidateCallback to reject exact matches of the typo.

[Kaelyn Takata]

On Tue, Jun 17, 2014 at 2:45 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Tue, Jun 17, 2014 at 2:14 PM, Kaelyn Takata <rikka at google.com> wrote:
> >
> > Also be more proactive about checking a correction's visibility so that
> > a correction requiring a module import can be distinguished from the
> > original typo even if it looks identical. Otherwise the correction will
> > be excluded and the diagnostic about needing the module import won't be
> > emitted.
> >
> > Note that the only change to checkCorrectionVisibility other than moving
> > where it is at in SemaLookup.cpp is to remove a parameter that was never
> > used within the function.
>
> Is it possible to remove that parameter in a precursor commit? You can
> just do that right away without code review, presumably.
>

D'oh. Yeah, you're right. I'll do that as part of respinning the patch set
(to include the changes for passing unique_ptrs by value and more
importantly to split apart two patches where a major patch somehow got
squashed into a minor patch).


> > ---
> >  include/clang/Sema/TypoCorrection.h |  26 +++++++--
> >  lib/Sema/SemaLookup.cpp             | 103
> +++++++++++++++++++-----------------
> >  2 files changed, 76 insertions(+), 53 deletions(-)
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140617/d43aa6c6/attachment.html>