[PATCH] MS local statics mangling: don't count enum scopes

Hans Wennborg hans at chromium.org
Mon Jun 16 15:38:40 PDT 2014


================
Comment at: include/clang/Sema/Scope.h:116
@@ -114,1 +115,3 @@
+    /// This scope corresponds to an enum.
+    EnumScope = 0x40000
   };
----------------
David Majnemer wrote:
> Please make this enumerator end with a comma, it will make the history nicer in the future when somebody else needs to add something here.
I guess this is legal now that we're using C++11, and I see the motivation, but do we generally do this in Clang or LLVM? I feel like I've seen other enumerations ending with a comma.

http://reviews.llvm.org/D4164






More information about the cfe-commits mailing list