[PATCH] Use the integrated assembler by default on OpenBSD/powerpc
Daniel Sanders
Daniel.Sanders at imgtec.com
Mon Jun 16 09:04:44 PDT 2014
> +// Check that the integrated assembler is enabld for PowerPC // RUN:
> +%clang -target powerpc-unknown-openbsd -### -c %s 2>&1 \
I assume something corrupted the line break on those two lines. There's also a typo in 'enabled' but other than that the patch looks good to me.
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-
> bounces at cs.uiuc.edu] On Behalf Of Brad Smith
> Sent: 14 June 2014 00:56
> To: cfe-commits at cs.uiuc.edu
> Subject: Re: [PATCH] Use the integrated assembler by default on
> OpenBSD/powerpc
>
> On Sun, Dec 29, 2013 at 03:22:05PM -0500, Brad Smith wrote:
> > Use the integrated assembler by default on OpenBSD/powerpc.
>
> How about this?
>
>
> Index: lib/Driver/ToolChains.h
> ==========================================================
> =========
> --- lib/Driver/ToolChains.h (revision 210958)
> +++ lib/Driver/ToolChains.h (working copy)
> @@ -537,6 +537,12 @@
> return 2;
> }
>
> + virtual bool IsIntegratedAssemblerDefault() const {
> + if (getTriple().getArch() == llvm::Triple::ppc)
> + return true;
> + return Generic_ELF::IsIntegratedAssemblerDefault();
> + }
> +
> protected:
> Tool *buildAssembler() const override;
> Tool *buildLinker() const override;
> Index: test/Driver/openbsd.c
> ==========================================================
> =========
> --- test/Driver/openbsd.c (revision 210958)
> +++ test/Driver/openbsd.c (working copy)
> @@ -59,3 +59,8 @@
> // CHECK-MIPS64-PIC: as{{.*}}" "-mabi" "64" "-EB" "-KPIC"
> // CHECK-MIPS64EL: as{{.*}}" "-mabi" "64" "-EL"
> // CHECK-MIPS64EL-PIC: as{{.*}}" "-mabi" "64" "-EL" "-KPIC"
> +
> +// Check that the integrated assembler is enabld for PowerPC // RUN:
> +%clang -target powerpc-unknown-openbsd -### -c %s 2>&1 \
> +// RUN: | FileCheck -check-prefix=CHECK-POWERPC-AS %s
> +// CHECK-POWERPC-AS-NOT: "-no-integrated-as"
>
> --
> This message has been scanned for viruses and dangerous content by
> MailScanner, and is believed to be clean.
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
More information about the cfe-commits
mailing list