[PATCH] Proposal on how to fix temporary dtors.

Manuel Klimek klimek at google.com
Sun Jun 15 08:39:20 PDT 2014


Sometimes it helps to try to write a nice commit message to find the flaws in one's thinking.

Consider:
  void testSequencingOfConditionalTempDtors(bool b) {
     b || (check(Dtor()), check(NoReturnDtor()));
     clang_analyzer_warnIfReached();  // expected-warning{{REACHABLE}}
   }

I assume this should pass. We need to put the decision point before the full sequence of unconditional we find. I got confused by the 'normal-order/bottom-up' build (/me headdesks appropriately to punish himself).
I'll continue working on it.

http://reviews.llvm.org/D3627






More information about the cfe-commits mailing list