[libcxx] r210857 - Revert "fixes duplicate header installation"

David Fang fang at csl.cornell.edu
Fri Jun 13 15:43:21 PDT 2014


Sorry about that, that was a result of using "git revert" and "git svn 
dcommit" to revert.
Original patch submitter (Ryuta) and a problem reporter are looking into 
why it didn't work for them (separate thread off-list).
Will report back in bug 18681.

David

> Problems were reported on the original commit thread. The revert commit log
> would do well to mention that along with the revision number rather than a
> hash....
>
>
> On Fri, Jun 13, 2014 at 2:02 PM, Rafael EspĂ­ndola <
> rafael.espindola at gmail.com> wrote:
>
>> why?
>>
>> On 12 June 2014 19:19, David Fang <fang at csl.cornell.edu> wrote:
>>> Author: fangism
>>> Date: Thu Jun 12 18:19:55 2014
>>> New Revision: 210857
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=210857&view=rev
>>> Log:
>>> Revert "fixes duplicate header installation"
>>>
>>> This reverts commit 0bd40d6c3da6719fecf77038673d453ff1eab25b.
>>>
>>> Modified:
>>>     libcxx/trunk/CMakeLists.txt
>>>
>>> Modified: libcxx/trunk/CMakeLists.txt
>>> URL:
>> http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=210857&r1=210856&r2=210857&view=diff
>>>
>> ==============================================================================
>>> --- libcxx/trunk/CMakeLists.txt (original)
>>> +++ libcxx/trunk/CMakeLists.txt Thu Jun 12 18:19:55 2014
>>> @@ -123,9 +123,13 @@ macro(setup_abi_lib abipathvar abidefine
>>>        message(FATAL_ERROR "Failed to find ${fpath}")
>>>      endif()
>>>    endforeach()
>>> +  add_custom_target(abilib_headers DEPENDS ${LIBCXX_CXX_ABI_DEPS})
>>> +  set(LIBCXX_CXX_ABI_DEPS abilib_headers)
>>>    include_directories("${CMAKE_BINARY_DIR}/include")
>>> -  install(FILES ${LIBCXX_CXX_ABI_DEPS}
>>> +  install(DIRECTORY "${CMAKE_BINARY_DIR}/include/"
>>>      DESTINATION include/c++/v1
>>> +    FILES_MATCHING
>>> +    PATTERN "*"
>>>      )
>>>  endmacro()
>>>
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>

-- 
David Fang
http://www.csl.cornell.edu/~fang/


More information about the cfe-commits mailing list