[PATCH] Recover from missing 'typename' in sizeof(T::InnerType)

Reid Kleckner rnk at google.com
Thu Jun 12 16:11:16 PDT 2014


Thanks!

================
Comment at: lib/Sema/TreeTransform.h:6871
@@ +6870,3 @@
+      PE ? dyn_cast<DependentScopeDeclRefExpr>(PE->getSubExpr()) : nullptr;
+  if (PE && DRE)
+    SubExpr = getDerived().TransformParenDependentScopeDeclRefExpr(
----------------
Richard Smith wrote:
> It's sufficient to only test `DRE` here (you could also move the declaration of `DRE` into the `if`).
OK

================
Comment at: lib/Sema/TreeTransform.h:8282
@@ -8240,3 +8281,3 @@
                                                DependentScopeDeclRefExpr *E) {
-  return TransformDependentScopeDeclRefExpr(E, /*IsAddressOfOperand*/false);
+  return TransformDependentScopeDeclRefExpr(E, /*IsAddressOfOperand*/false, nullptr);
 }
----------------
Richard Smith wrote:
> My over-80-column sense is tingling...
yeah

http://reviews.llvm.org/D4108






More information about the cfe-commits mailing list