[PATCH] Driver: add support for linker file lists

Alp Toker alp at nuanti.com
Wed Jun 11 17:45:21 PDT 2014


On 12/06/2014 02:01, Reid Kleckner wrote:
> This is a general problem: any subcommand we execute may overflow the system command line length limit.  I'd rather solve it transparently for -cc1 as well as linker invocations by exposing a command line length estimate from Support and then estimating our command line length in the driver before invoking the subcommand, optionally with a response file.

Hmm, you might be onto something..

I'm wonder if could be implemented more cleanly as an additional step 
after the Compilation has been built, somewhere near the end of 
Driver::BuildCompilation(), or perhaps in its callers which know about 
the full command line length.

Apart from solving the automation problem, that also feels more 
idiomatic/elegant. I don't know if it's practical to mutate that data 
structure in practice though.

Alp.



>    I know that Sony has an internal patch to do this for -cc1 invocations, so it's not just linker stuff.
>
> http://reviews.llvm.org/D4104
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-- 
http://www.nuanti.com
the browser experts




More information about the cfe-commits mailing list