r210713 - Don't slice SemaDiagnosticBuilder

Reid Kleckner reid at kleckner.net
Wed Jun 11 14:57:16 PDT 2014


Author: rnk
Date: Wed Jun 11 16:57:15 2014
New Revision: 210713

URL: http://llvm.org/viewvc/llvm-project?rev=210713&view=rev
Log:
Don't slice SemaDiagnosticBuilder

I wasn't able to figure out how to emit this diagnostic from a SFINAE
context, so I don't have a test.

Modified:
    cfe/trunk/lib/Sema/SemaExpr.cpp

Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=210713&r1=210712&r2=210713&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Wed Jun 11 16:57:15 2014
@@ -1952,9 +1952,8 @@ recoverFromMSUnqualifiedLookup(Sema &S,
   // Diagnose this as unqualified lookup into a dependent base class.  If 'this'
   // is available, suggest inserting 'this->' as a fixit.
   SourceLocation Loc = NameInfo.getLoc();
-  DiagnosticBuilder DB =
-      S.Diag(Loc, diag::ext_undeclared_unqual_id_with_dependent_base)
-      << NameInfo.getName() << RD;
+  auto DB = S.Diag(Loc, diag::ext_undeclared_unqual_id_with_dependent_base);
+  DB << NameInfo.getName() << RD;
 
   if (!ThisType.isNull()) {
     DB << FixItHint::CreateInsertion(Loc, "this->");





More information about the cfe-commits mailing list