r210584 - Fix crash with x86_64-pc-win32-macho target. <rdar://problem/17235840>

[Bob Wilson]

> On Jun 11, 2014, at 8:57 AM, Chandler Carruth <chandlerc at google.com> wrote:
> 
> 
> On Wed, Jun 11, 2014 at 4:41 PM, Bob Wilson <bob.wilson at apple.com> wrote:
> > On Jun 10, 2014, at 6:07 PM, David Blaikie <dblaikie at gmail.com> wrote:
> >
> > On Tue, Jun 10, 2014 at 6:04 PM, Bob Wilson <bob.wilson at apple.com> wrote:
> >> Thanks for fixing the output to the source tree. I should have caught that.
> >>
> >> I don’t especially know what to test for here. I wasn’t involved in setting up this win32-macho stuff, and I don’t know much about how it works. Apparently whoever did set it up neglected to add any tests. I won’t claim this is a good test, but it is far better than what we had before (nothing!). If someone who knows about this can provide a better test, then that would be great.
> >
> > So how'd you come across the issue? I assume you're /using/ it, in
> > which case it might be useful to add some tests/understand how it
> > works...
> 
> No, I’m not personally using it at all. I know there are some people at Apple who do. I received a bug report saying that it crashes, so I fixed the crash. I agree that it would be very useful to have some good tests, but I don’t know enough about it to do that.
> 
> Well, if you're supporting the only users of it (and it seems you are) could you find out how to test it better or find the people know about this?
> 
> If there is no one around who knows how to test this stuff, then it is essentially being left in an unmaintained state. That's no good. If we really can't find anyone to maintain it, I worry need to rip it out because it will continue to bit rot. That process seems to have already started as this crash uncovered.

There’s a big difference between “I don’t know how to write good tests for this” and “we need to rip it out because no one is maintaining it”. We will definitely maintain it, and we (Apple) will have to deal with the pain caused by the lack of good tests. It basically means that we are stuck waiting to find problems when people use it, rather than catching them earlier when we run the test suite. We can add tests for those issues as they arise.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140611/019cf8ab/attachment.html>