[PATCH] Rewrite arm_neon.h generation from scratch

[James Molloy]

Hi all,

Ping? :)

James

> -----Original Message-----
> From: Renato Golin [mailto:renato.golin at linaro.org]
> Sent: 05 June 2014 21:32
> To: James Molloy
> Cc: Clang Commits; Tim Northover; Jiangning Liu; Hao Liu; Amara Emerson;
> Jim Grosbach
> Subject: Re: [PATCH] Rewrite arm_neon.h generation from scratch
>
> On 4 June 2014 11:39, James Molloy <james.molloy at arm.com> wrote:
> > Here's an example: before:
> >
> >   case OpAbdl: {
> >     std::string abd = MangleName("vabd", typestr, ClassS) + "(__a,
> __b)";
> >     if (typestr[0] != 'U') {
> >       // vabd results are always unsigned and must be zero-extended.
> >       std::string utype = "U" + typestr.str();
> >       s += "(" + TypeString(proto[0], typestr) + ")";
> >       abd = "(" + TypeString('d', utype) + ")" + abd;
> >       s += Extend(utype, abd) + ";";
> >     } else {
> >       s += Extend(typestr, abd) + ";";
> >     }
> >     break;
> >   }
> >
> > after:
> >
> >   def OP_ABDL     : Op<(cast "R", (call "vmovl", (cast $p0, "U",
> >                                                        (call "vabd",
> $p0,
> > $p1))))>;
>
> Shut up and take my money!
>
> On the patches, the SetTheory files are new, but there are no deleted
> files. Are you moving, or just copying?
>
> Also, the other patch seems a much cleaner TableGen file, but the C++
> file got completely messed up by patch thinking that close function
> curly brackets is "equal" no matter which function they belong. You'd
> think that after several decades using diff for patch review they
> would begin to understand the concept of functions, structures, etc.
>
> Anyway, I like the idea and I think it's an important move. I'm not
> too bothered about the weird test cases, as long as the remaining ones
> have a similar coverage.
>
> cheers,
> -renato


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2548782