[PATCH] Allow lookup into dependent bases in static methods under -fms-compatibility

[Reid Kleckner]

Thanks!

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3661
@@ -3660,1 +3660,3 @@
 def err_undeclared_var_use : Error<"use of undeclared identifier %0">;
+def warn_undeclared_unqual_id_with_dependent_base : ExtWarn<
+  "use of undeclared identifier %0; "
----------------
Richard Smith wrote:
> Should be `ext_...`
done

================
Comment at: lib/Sema/SemaExpr.cpp:1954
@@ +1953,3 @@
+  SourceLocation Loc = NameInfo.getLoc();
+  unsigned DI = diag::warn_undeclared_unqual_id_with_dependent_base;
+  DiagnosticBuilder DB = S.Diag(Loc, DI) << NameInfo.getName() << RD;
----------------
Richard Smith wrote:
> Maybe fold this into the `S.Diag` call below?
done, previously the formatting was horrible

================
Comment at: lib/Sema/SemaExpr.cpp:1960-1961
@@ +1959,4 @@
+
+    // Since the 'this' expression is synthesized, we don't need to
+    // perform the double-lookup check.
+    NamedDecl *FirstQualifierInScope = nullptr;
----------------
Richard Smith wrote:
> I don't think this comment makes much sense in its new context; maybe just remove it?
done.

http://reviews.llvm.org/D4079