[PATCH] Using of variable length arrays in captured statements and OpenMP constructs

[Hal Finkel]

----- Original Message -----
> From: "Jim Cownie" <james.h.cownie at intel.com>
> To: "a bataev" <a.bataev at hotmail.com>, dgregor at apple.com, hfinkel at anl.gov, cbergstrom at pathscale.com,
> fraggamuffin at gmail.com, richard at metafoo.co.uk, rjmccall at gmail.com
> Cc: "james h cownie" <james.h.cownie at intel.com>, cfe-commits at cs.uiuc.edu
> Sent: Monday, June 9, 2014 6:13:09 AM
> Subject: Re: [PATCH] Using of variable length arrays in captured statements and OpenMP constructs
> 
> This looks very dubious
> lib/CodeGen/CGStmt.cpp : 2076
>   assert(CD->hasBody() && "missing CapturedDecl body");
> 
> I believe the "&&" should be a comma.

No, this looks fine (and follows the LLVM coding convention, see: http://llvm.org/docs/CodingStandards.html#assert-liberally).

 -Hal

> 
> http://reviews.llvm.org/D4067
> 
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory