[PATCH] Simplify microsoft mangling of template instantiations

David Majnemer david.majnemer at gmail.com
Fri Jun 6 11:41:52 PDT 2014


On Fri, Jun 6, 2014 at 5:33 AM, Timur Iskhodzhanov <timurrrr at google.com>
wrote:

> The change looks good -- it simplifies the code and makes it faster.
>
> David,
> Do you have a good way to make sure we don't regress other than
> commit-and-see-if-it-explodes?
>

Sadly not but our in-tree tests are pretty thorough for templates.


>
> ================
> Comment at: lib/AST/MicrosoftMangle.cpp:678
> @@ +677,3 @@
> +    if (Found == NameBackReferences.end()) {
> +      Out << BackReferenceKey;
> +      if (NameBackReferences.size() < 10) {
> ----------------
> This variable is no longer used as just a key.
> Please use something like `TemplateMangling` or `TDMangling` instead?
>
> http://reviews.llvm.org/D3983
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140606/395fbac0/attachment.html>


More information about the cfe-commits mailing list