[PATCH] PR11306 - Variadic template fix-it suggestion

Richard Smith richard at metafoo.co.uk
Thu Jun 5 18:06:35 PDT 2014


Thanks, this looks much nicer.

================
Comment at: lib/Parse/ParseTemplate.cpp:503
@@ +502,3 @@
+  if (TryConsumeToken(tok::ellipsis, EllipsisLoc))
+    DiagnoseMisplacedEllipsis(EllipsisLoc, NameLoc, false, true);
+
----------------
I don't think your `AlreadyHasEllipsis` argument here is correct; we might have parsed one a few lines above.

================
Comment at: lib/Parse/ParseTemplate.cpp:588
@@ +587,3 @@
+  if (TryConsumeToken(tok::ellipsis, EllipsisLoc))
+    DiagnoseMisplacedEllipsis(EllipsisLoc, NameLoc, false, true);
+
----------------
Likewise here.

http://reviews.llvm.org/D3604






More information about the cfe-commits mailing list