count() patch to unsigned for DenseMap, DenseSet, ScopedHashTable, ValueMap

[Yaron Keren]

http://reviews.llvm.org/D4018

Updated upatch to ToT, fixed comments and two warnings.



2014-06-04 0:11 GMT+03:00 Rafael Espíndola <rafael.espindola at gmail.com>:

> +  /// count -
>
> While at it, please drop the name from the comment.
>
> I think the patch is OK. Richard, do you know what is the reason the
> stl uses size_type?
>
>
> On 23 December 2013 06:51, Yaron Keren <yaron.keren at gmail.com> wrote:
> > The count() function for STL datatypes returns unsigned, even where it's
> > only 1/0 result like std::set. Some of the LLVM ADT already return
> unsigned
> > count(), while others still return bool count().
> >
> > In continuation to r197879, this patch modifies DenseMap, DenseSet,
> > ScopedHashTable, ValueMap:: count() to return unsigned instead of bool, 1
> > instead of true and 0 instead of false.
> >
> > Yaron
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140604/e5781ad2/attachment.html>