[PATCH] libcxxabi/unwind: Add support for ARM EHABI _Unwind_VRS_Set/Get/Pop methods.

Albert Wong (王重傑) ajwong at google.com
Tue Jun 3 16:28:08 PDT 2014


On Tue, Jun 3, 2014 at 5:49 PM, Renato Golin <renato.golin at linaro.org>
wrote:

> On 2 June 2014 18:02, Dana Jansens <danakj at google.com> wrote:
> > Hi Nick,
> >
> > This patch builds on my previous patch[1] (using the config.h #define) to
> > provide the virtual register set methods from the ARM EHABI ssection 7.5.
>
>
> Hi Dana,
>
> +    case _UVRSC_VFP: {
> +      unw_fpreg_t value;
> +      switch (representation) {
> +        case _UVRSD_VFPX:
> +          // TODO(ajwong): What does this mean?
> +          break;
>
> Isn't this just a VLDM/VSTM into/from D registers? Should be similar
> to the other 64-bit cases, no?
>
> The rest looks ok to me, but please wait for Nick's review before commit.
>

FYI, this is an incremental patch. The VFP support is still being fully
validated but there will be a followup patch soon. If you'd prefer, we can
push all of the VFP and core register bits at once. It'll be a bigish patch
though.


>
> cheers,
> --renato
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140604/94b7b7b7/attachment.html>


More information about the cfe-commits mailing list