r210096 - temporary disable part of a test because it causes clang to leak memory (want to have the sanitizer bot green)

[David Blaikie]

On Jun 3, 2014 8:04 AM, "Kostya Serebryany" <kcc at google.com> wrote:
>
>
>
>
> On Tue, Jun 3, 2014 at 6:50 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> Would am xfail be better. That should cause the test to fail to fail
when this bug is fixed, promoting someone to in xfail it and raise the bar.
>
>
> I tried
>  XFAIL: *
> but this breaks when I am not running with lsan because w/o lsan the test
passes.

Right, you'd need to teach lit about an lsan feature name if it doesn't
know already, like we have for valgrind (and specifically valgrind leak
detection: XFAIL: vg_leak, if I recall correctly)

> Or you are suggesting something else?
>
>>
>> On Jun 3, 2014 4:55 AM, "Kostya Serebryany" <kcc at google.com> wrote:
>>>
>>> Author: kcc
>>> Date: Tue Jun  3 06:45:37 2014
>>> New Revision: 210096
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=210096&view=rev
>>> Log:
>>> temporary disable part of a test because it causes clang to leak memory
(want to have the sanitizer bot green)
>>>
>>> Modified:
>>>     cfe/trunk/test/Frontend/disable-output.c
>>>
>>> Modified: cfe/trunk/test/Frontend/disable-output.c
>>> URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/disable-output.c?rev=210096&r1=210095&r2=210096&view=diff
>>>
==============================================================================
>>> --- cfe/trunk/test/Frontend/disable-output.c (original)
>>> +++ cfe/trunk/test/Frontend/disable-output.c Tue Jun  3 06:45:37 2014
>>> @@ -1,7 +1,8 @@
>>> +// FIXME: this test produces a leak report in clang.
>>>  // REQUIRES: x86-registered-target
>>>  // RUN: %clang_cc1 %s -emit-llvm-only -triple=i386-apple-darwin -o %t
>>>  // RUN: not rm %t
>>> -// RUN: %clang_cc1 %s -emit-codegen-only -triple=i386-apple-darwin -o
%t
>>> -// RUN: not rm %t
>>> +// FIXME: %clang_cc1 %s -emit-codegen-only -triple=i386-apple-darwin
-o %t
>>> +// FIXME: not rm %t
>>>
>>>  // Test that output is not generated when emission is disabled.
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140603/ac3ea317/attachment.html>