[PATCH] Take into account PrintingPolicy::SuppressUnwrittenScope in NamedDecl::printQualifiedName.

Richard Smith richard at metafoo.co.uk
Fri May 30 15:24:41 PDT 2014


Committed as r209924. Thanks!


On Fri, May 30, 2014 at 5:34 AM, Volodymyr Sapsai <
volodymyr.sapsai at gmail.com> wrote:

> Please, commit for me.
>
>
> On Fri, May 30, 2014 at 6:05 AM, Richard Smith <richard at metafoo.co.uk>
> wrote:
>
>> Do you have commit access, or would you like me to commit this for you?
>>
>>
>> On Thu, May 29, 2014 at 8:04 PM, Richard Smith <richard at metafoo.co.uk>
>> wrote:
>>
>>> LGTM
>>>
>>> ================
>>> Comment at: lib/AST/Decl.cpp:1307
>>> @@ +1306,3 @@
>>> +      if (P.SuppressUnwrittenScope &&
>>> +          (ND->isAnonymousNamespace() || ND->isInlineNamespace()))
>>> +        continue;
>>> ----------------
>>> Just use `isInline` here since you already know you've got a namespace.
>>>
>>> http://reviews.llvm.org/D3922
>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140530/dcdee056/attachment.html>


More information about the cfe-commits mailing list