[libcxx] r209888 - Add a _LIBCPP_CONSTEXPR that was missed in r170026.

[Nico Weber]

On Fri, May 30, 2014 at 7:39 PM, Richard Smith <richard at metafoo.co.uk>
wrote:

>
> On 30 May 2014 05:36, "Nico Weber" <thakis at chromium.org> wrote:
> >
> > (Filed http://llvm.org/bugs/show_bug.cgi?id=19897 for clang not
> diagnosing the missing constexpr.)
>
> This is a GCC bug, not a Clang bug. The code was correct without the
> change. (Though it seems reasonable for GCC compatibility)
>
The other > 100 lines like this that were added in r170026 all have
_LIBCPP_CONSTEXPR too, so it definitely looks like this line was missed
unintentionally :-P

>  > On Fri, May 30, 2014 at 2:09 PM, Nico Weber <nicolasweber at gmx.de>
> wrote:
> >>
> >> Author: nico
> >> Date: Fri May 30 07:09:47 2014
> >> New Revision: 209888
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=209888&view=rev
> >> Log:
> >> Add a _LIBCPP_CONSTEXPR that was missed in r170026.
> >>
> >> (clang doesn't complain about this, but gcc does.  This is necessary
> for a
> >> follow-up patch that will enable _LIBCPP_CONSTEXPR for gcc.)
> >>
> >> Modified:
> >>     libcxx/trunk/include/limits
> >>
> >> Modified: libcxx/trunk/include/limits
> >> URL:
> http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/limits?rev=209888&r1=209887&r2=209888&view=diff
> >>
> ==============================================================================
> >> --- libcxx/trunk/include/limits (original)
> >> +++ libcxx/trunk/include/limits Fri May 30 07:09:47 2014
> >> @@ -768,7 +768,7 @@ template <class _Tp>
> >>  template <class _Tp>
> >>      _LIBCPP_CONSTEXPR const int numeric_limits<const volatile
> _Tp>::digits10;
> >>  template <class _Tp>
> >> -    const int numeric_limits<const volatile _Tp>::max_digits10;
> >> +    _LIBCPP_CONSTEXPR const int numeric_limits<const volatile
> _Tp>::max_digits10;
> >>  template <class _Tp>
> >>      _LIBCPP_CONSTEXPR const bool numeric_limits<const volatile
> _Tp>::is_signed;
> >>  template <class _Tp>
> >>
> >>
> >> _______________________________________________
> >> cfe-commits mailing list
> >> cfe-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140530/6d9badd7/attachment.html>