[PATCH] [OPENMP] Loop canonical form analysis (Sema)

Richard Smith richard at metafoo.co.uk
Thu May 29 20:51:06 PDT 2014


On Wed, May 28, 2014 at 6:09 AM, Alexander Musman <
alexander.musman at gmail.com> wrote:

> Richard,
>
> Yes, I think that assuming that the variable is random access iterator
> would work. It will still need to generate std::difference on them,


I don't think even that's necessary: the random access iterator
requirements let you use `it2 - it2`. (And that's just as well; it'd be
weird for a language feature to require `std::difference` to be available
-- not that there aren't other language features like that, but still...)

but we can check that later, during building expressions for iteration
> space (that will be used for CodeGen). This also has an advantage that user
> may use his iterators without deriving from std classes.
> I've removed corresponding checks and fixed processing `break` statements.
>
> Thanks,
> Alexander
>
> http://reviews.llvm.org/D3778
>
> Files:
>   include/clang/Basic/DiagnosticSemaKinds.td
>   include/clang/Sema/Scope.h
>   include/clang/Sema/Sema.h
>   lib/Parse/ParseOpenMP.cpp
>   lib/Sema/Scope.cpp
>   lib/Sema/SemaOpenMP.cpp
>   lib/Sema/SemaStmt.cpp
>   test/OpenMP/simd_loop_messages.cpp
>   test/OpenMP/simd_misc_messages.c
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140529/75115ac2/attachment.html>


More information about the cfe-commits mailing list