r209869 - PR11410 - Confusing diagnostic when trailing array element tries to call deleted default constructor

Nikola Smiljanic popizdeh at gmail.com
Thu May 29 20:13:47 PDT 2014


>
> That should read "default-constructed".
>

Could you elaborate? English is not my native language and grepping the
source code didn't produce anything useful.


> The message can be made shorter by dropping the first half without losing
> value -- the source location is sufficiently informative.
>

I don't think it's obvious without the first part but I'll change it if you
insist? I've just noticed that 'omitted element' probably needs a plural
version.


> It's unconventional to use 'was' when describing semantic analysis results.


How about 'parameter 0% was not declared' or 'unnamed type used in template
argument was declared here'. There are many others and to me they feel more
natural, but again I'm not a native speaker. I actually don't like that
terse mechanical voice compilers often have.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140530/9c6b2fed/attachment.html>


More information about the cfe-commits mailing list