[PATCH] MS ABI: Treat dllimport explicit specializations as inline

[Nico Rieck]

On 29.05.2014 23:25, Richard Smith wrote:
> I find it a bit weird that we care in CodeGen whether a dllimport function
> is marked as 'inline'. I would expect that either Sema should detect the
> attribute has no effect and discard it, or it should keep it (and in the
> latter case, CodeGen should respect it and not care whether the function is
> marked 'inline'). Is there some reason that doesn't work?

The first patch is bit backwards and unnecessarily complex. MSVC emits
non-imported specializations with ODR linkage.

So a simpler way to deal with this would be to just do what this mail's
subject says and make such a specialization implictly inline which
resolves correctly to available_externally without doing anything
further. New patch attached.

-Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ms-abi-dllimport-explicit-specializations-v2.patch
Type: text/x-patch
Size: 12352 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140530/78cf676a/attachment.bin>