[PATCH] make clang/tools/extra unittest run,

[Eric Christopher]

On Wednesday, May 28, 2014, Alp Toker <alp at nuanti.com> wrote:

>
> On 29/05/2014 03:44, Eric Christopher wrote:
>
>> On Wed, May 28, 2014 at 5:41 PM, Alp Toker <alp at nuanti.com> wrote:
>>
>>> Hi Iain,
>>>
>>> I noticed your Makefile updates including this one and lld...
>>>
>>>
>>>
>>> On 28/05/2014 23:25, Iain Sandoe wrote:
>>>
>>>> Hi,
>>>>
>>>> Is there some reason that the unitttests are not run for
>>>> clang/tools/extra?
>>>>
>>>
>>> The makefile build systems have felt moderately deprecated for some time.
>>> There are odds and ends that are only available in the CMake build
>>> system,
>>> particularly tests/examples/documentation -- mostly unnoticed, so we can
>>> infer that developers/users have mostly switched by now.
>>>
>>> Do we really want to begin adding new features to the makefiles again at
>>> this point -- is there something it can do that the primary one can't?
>>>
>>> CMake lets us target multiple platforms equally, generating fast parallel
>>> builds with ninja and letting us drop the GNU make dependency for a
>>> lighter
>>> build environment.
>>>
>>> If there's any remaining limitation it seems more appropriate to address
>>> those and keep moving gently towards a single build system.
>>>
>>>  Sadly there are currently enough limitations that it's worth at least
>> making sure that basic functionality is shared if possible.
>>
>
> Are we tracking those limitations somewhere?
>
>
Pretty sure yes. There's a pr for it I think. I don't have the number handy.

-eric


> Alp.
>
>
>
>> -eric
>>
>>  Alp.
>>>
>>>
>>>
>>>  if not, then the following trivial patch makes them run (they do so
>>>> without error on osx 10.8).
>>>>
>>>> Iain
>>>>
>>>> diff --git a/llvm/test/Makefile b/llvm/test/Makefile
>>>> index dc99fe1..20ebb78 100644
>>>> --- a/llvm/test/Makefile
>>>> +++ b/llvm/test/Makefile
>>>> @@ -57,7 +57,7 @@ LIT_ALL_TESTSUITES +=
>>>> $(PROJ_OBJ_DIR)/../tools/clang/tools/extra/test
>>>>      # Force creation of Clang Tools' lit.site.cfg.
>>>>    clang-tools-site-cfg: FORCE
>>>> -       $(MAKE) -C $(PROJ_OBJ_DIR)/../tools/clang/tools/extra/test
>>>> lit.site.cfg
>>>> +       $(MAKE) -C $(PROJ_OBJ_DIR)/../tools/clang/tools/extra/test
>>>> lit.site.cfg Unit/lit.site.cfg
>>>>    extra-site-cfgs:: clang-tools-site-cfg
>>>>    endif
>>>>
>>>>
>>>> _______________________________________________
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>>
>>>
>>> --
>>> http://www.nuanti.com
>>> the browser experts
>>>
>>>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140528/e36e61b3/attachment.html>