[libc++ patch] Make meta.trans.other/aligned_storage.pass.cpp pass on arm

Marshall Clow mclow.lists at gmail.com
Wed May 28 07:04:27 PDT 2014


On May 28, 2014, at 4:36 AM, Nico Weber <thakis at chromium.org> wrote:

> Hi,
> 
> On arm, the maxium alignment is 8. The attached patch tweaks meta.trans.other/aligned_storage.pass.cpp so that it passes on arm. (The test currently assumes that alignment goes up to at least 16.)

Nico —

I’m a bit leery of 
	+ static_assert(std::alignment_of<T1>::value == alignof(T1), "");
b/c I’m not sure that it tests what we want to test here.

Is there some way that we can use max_align_t in this test?

Maybe something like (untested code):
	static_assert (  std::alignment_of<T1>::value == std::max(16, alignof(std::max_align_t));

— Marshall





More information about the cfe-commits mailing list