[PATCH] IRGen: Emit dllexport functions defined in-class

Nico Rieck nico.rieck at gmail.com
Fri May 23 15:00:08 PDT 2014


On 23.05.2014 18:58, Hans Wennborg wrote:
> This doesn't work for nested classes. When I talked about this with
> Richard, he called the code in ModuleBuilder::HandleTagDeclDefinition
> broken, and suggested the approach I'm trying in
> http://reviews.llvm.org/D3809

Ah that looks better. I must have missed that.

> Your tests are awesome though, we should definitely get those landed.

Apparently not awesome enough, or else I would have noticed. ;) I think
there actually are some tests for nested classes, but they don't use
inline functions. I'll update the IRGen tests for this change.

-Nico



More information about the cfe-commits mailing list