[PATCH] Don't suppress warning about dllimport on non-functions and variables

Hans Wennborg hans at chromium.org
Fri May 23 13:24:39 PDT 2014


I've committed this in r209546.

Thanks,
Hans

On Wed, May 21, 2014 at 9:07 AM, Hans Wennborg <hans at chromium.org> wrote:
> Yes, there are tests in Sema/dllimport.c for example.
>
> I'll wait a few more days to hear if Ted has any objections.
>
> On Wed, May 21, 2014 at 9:01 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
>> Do we have sufficient sema test coverage for the attribute applying to
>> variables and functions? Assuming that we do (which I believe may be
>> the case), then LGTM, unless Ted has other reasoning.
>>
>> ~Aaron
>>
>> On Wed, May 21, 2014 at 11:57 AM, Hans Wennborg <hans at chromium.org> wrote:
>>> Ping?
>>>
>>> http://reviews.llvm.org/D3832
>>>
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list