[clang-tools-extra] r209505 - clang-tidy: Only add 'override' before inlined bodies.

Daniel Jasper djasper at google.com
Fri May 23 01:52:11 PDT 2014


Author: djasper
Date: Fri May 23 03:52:10 2014
New Revision: 209505

URL: http://llvm.org/viewvc/llvm-project?rev=209505&view=rev
Log:
clang-tidy: Only add 'override' before inlined bodies.

Modified:
    clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp
    clang-tools-extra/trunk/test/clang-tidy/use-override.cpp

Modified: clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp?rev=209505&r1=209504&r2=209505&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/misc/UseOverride.cpp Fri May 23 03:52:10 2014
@@ -96,7 +96,8 @@ void UseOverride::check(const MatchFinde
       }
     }
 
-    if (InsertLoc.isInvalid() && Method->getBody()) {
+    if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody() &&
+        Method->getBody()) {
       InsertLoc = Method->getBody()->getLocStart();
     }
 

Modified: clang-tools-extra/trunk/test/clang-tidy/use-override.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/use-override.cpp?rev=209505&r1=209504&r2=209505&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/use-override.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/use-override.cpp Fri May 23 03:52:10 2014
@@ -59,6 +59,9 @@ public:
 void SimpleCases::i() {}
 // CHECK: {{^void SimpleCases::i\(\) {}}}
 
+SimpleCases::~SimpleCases() {}
+// CHECK: {{^SimpleCases::~SimpleCases\(\) {}}}
+
 struct InlineDefinitions : public Base {
 public:
   virtual ~InlineDefinitions() {}





More information about the cfe-commits mailing list