r209477 - Use error_code::success() instead of make_error_code(llvm::errc::success).

Tobias Grosser tobias at grosser.es
Thu May 22 23:16:43 PDT 2014


On 23/05/2014 00:06, Alexander Kornienko wrote:
> Author: alexfh
> Date: Thu May 22 17:06:08 2014
> New Revision: 209477
>
> URL: http://llvm.org/viewvc/llvm-project?rev=209477&view=rev
> Log:
> Use error_code::success() instead of make_error_code(llvm::errc::success).
>
>
> Modified:
>      cfe/trunk/lib/Format/Format.cpp
>
> Modified: cfe/trunk/lib/Format/Format.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=209477&r1=209476&r2=209477&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Format/Format.cpp (original)
> +++ cfe/trunk/lib/Format/Format.cpp Thu May 22 17:06:08 2014
> @@ -482,7 +482,7 @@ llvm::error_code parseConfiguration(Stri
>           Styles[i].Language == FormatStyle::LK_None) {
>         *Style = Styles[i];
>         Style->Language = Language;
> -      return llvm::make_error_code(llvm::errc::success);
> +      return llvm::error_code::success();

Just out of interest, what is the improvement. Just because it is 
slightly shorter?

>       }
>     }
>     return llvm::make_error_code(llvm::errc::not_supported);

Should this line be changed too?

Tobias




More information about the cfe-commits mailing list