r209215 - Clean up language and grammar.

Jordan Rose jordan_rose at apple.com
Tue May 20 11:34:02 PDT 2014


s/he/they/ much appreciated. :-)

On May 20, 2014, at 10:10 , Eric Christopher <echristo at gmail.com> wrote:

> Author: echristo
> Date: Tue May 20 12:10:39 2014
> New Revision: 209215
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=209215&view=rev
> Log:
> Clean up language and grammar.
> 
> Based on a patch by jfcaron3 at gmail.com!
> PR19806
> 
> Modified:
>    cfe/trunk/bindings/python/clang/cindex.py
>    cfe/trunk/docs/SanitizerSpecialCaseList.rst
>    cfe/trunk/include/clang/Basic/DiagnosticCommentKinds.td
>    cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp
>    cfe/trunk/lib/CodeGen/CGExpr.cpp
>    cfe/trunk/lib/Sema/SemaObjCProperty.cpp
>    cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSizeofPointer.cpp
>    cfe/trunk/test/Analysis/misc-ps-region-store.m
>    cfe/trunk/test/CXX/except/except.spec/p11.cpp
> 
> Modified: cfe/trunk/bindings/python/clang/cindex.py
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/bindings/python/clang/cindex.py?rev=209215&r1=209214&r2=209215&view=diff
> ==============================================================================
> --- cfe/trunk/bindings/python/clang/cindex.py (original)
> +++ cfe/trunk/bindings/python/clang/cindex.py Tue May 20 12:10:39 2014
> @@ -3404,8 +3404,8 @@ class Config:
>         python bindings can disable the compatibility check. This will cause
>         the python bindings to load, even though they are written for a newer
>         version of libclang. Failures now arise if unsupported or incompatible
> -        features are accessed. The user is required to test himself if the
> -        features he is using are available and compatible between different
> +        features are accessed. The user is required to test themselves if the
> +        features they are using are available and compatible between different
>         libclang versions.
>         """
>         if Config.loaded:
> 
> Modified: cfe/trunk/docs/SanitizerSpecialCaseList.rst
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/SanitizerSpecialCaseList.rst?rev=209215&r1=209214&r2=209215&view=diff
> ==============================================================================
> --- cfe/trunk/docs/SanitizerSpecialCaseList.rst (original)
> +++ cfe/trunk/docs/SanitizerSpecialCaseList.rst Tue May 20 12:10:39 2014
> @@ -24,7 +24,7 @@ certain source-level entities to:
>   thread stack, bypassing the frame boundaries);
> * ignore a known problem.
> 
> -To achieve this, user may create a file listing the entities he wants to
> +To achieve this, user may create a file listing the entities they want to
> ignore, and pass it to clang at compile-time using
> ``-fsanitize-blacklist`` flag. See :doc:`UsersManual` for details.
> 
> 
> Modified: cfe/trunk/include/clang/Basic/DiagnosticCommentKinds.td
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticCommentKinds.td?rev=209215&r1=209214&r2=209215&view=diff
> ==============================================================================
> --- cfe/trunk/include/clang/Basic/DiagnosticCommentKinds.td (original)
> +++ cfe/trunk/include/clang/Basic/DiagnosticCommentKinds.td Tue May 20 12:10:39 2014
> @@ -11,7 +11,7 @@ let Component = "Comment" in {
> let CategoryName = "Documentation Issue" in {
> 
> // HTML parsing errors.  These are under -Wdocumentation to make sure the user
> -// knows that we didn't parse something as he might expect.
> +// knows that we didn't parse something as they might expect.
> 
> def warn_doc_html_start_tag_expected_quoted_string : Warning<
>   "expected quoted string after equals sign">,
> 
> Modified: cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp?rev=209215&r1=209214&r2=209215&view=diff
> ==============================================================================
> --- cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp (original)
> +++ cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp Tue May 20 12:10:39 2014
> @@ -70,7 +70,7 @@ public:
>           // An unused autorelease is badness. If we remove it the receiver
>           // will likely die immediately while previously it was kept alive
>           // by the autorelease pool. This is bad practice in general, leave it
> -          // and emit an error to force the user to restructure his code.
> +          // and emit an error to force the user to restructure their code.
>           Pass.TA.reportError("it is not safe to remove an unused 'autorelease' "
>               "message; its receiver may be destroyed immediately",
>               E->getLocStart(), E->getSourceRange());
> 
> Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGExpr.cpp?rev=209215&r1=209214&r2=209215&view=diff
> ==============================================================================
> --- cfe/trunk/lib/CodeGen/CGExpr.cpp (original)
> +++ cfe/trunk/lib/CodeGen/CGExpr.cpp Tue May 20 12:10:39 2014
> @@ -1610,7 +1610,7 @@ void CodeGenFunction::EmitStoreThroughGl
>   Builder.CreateCall2(F, RegName, Value);
> }
> 
> -// setObjCGCLValueClass - sets class of he lvalue for the purpose of
> +// setObjCGCLValueClass - sets class of the lvalue for the purpose of
> // generating write-barries API. It is currently a global, ivar,
> // or neither.
> static void setObjCGCLValueClass(const ASTContext &Ctx, const Expr *E,
> 
> Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaObjCProperty.cpp?rev=209215&r1=209214&r2=209215&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Sema/SemaObjCProperty.cpp (original)
> +++ cfe/trunk/lib/Sema/SemaObjCProperty.cpp Tue May 20 12:10:39 2014
> @@ -1677,7 +1677,7 @@ void Sema::DiagnoseUnimplementedProperti
>       // Lazily construct a set of all the properties in the @interface
>       // of the class, without looking at the superclass.  We cannot
>       // use the call to CollectImmediateProperties() above as that
> -      // utilizes information fromt he super class's properties as well
> +      // utilizes information from the super class's properties as well
>       // as scans the adopted protocols.  This work only triggers for protocols
>       // with the attribute, which is very rare, and only occurs when
>       // analyzing the @implementation.
> 
> Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSizeofPointer.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSizeofPointer.cpp?rev=209215&r1=209214&r2=209215&view=diff
> ==============================================================================
> --- cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSizeofPointer.cpp (original)
> +++ cfe/trunk/lib/StaticAnalyzer/Checkers/CheckSizeofPointer.cpp Tue May 20 12:10:39 2014
> @@ -47,7 +47,7 @@ void WalkAST::VisitUnaryExprOrTypeTraitE
>   if (E->getKind() != UETT_SizeOf)
>     return;
> 
> -  // If an explicit type is used in the code, usually the coder knows what he is
> +  // If an explicit type is used in the code, usually the coder knows what they are
>   // doing.
>   if (E->isArgumentType())
>     return;
> 
> Modified: cfe/trunk/test/Analysis/misc-ps-region-store.m
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Analysis/misc-ps-region-store.m?rev=209215&r1=209214&r2=209215&view=diff
> ==============================================================================
> --- cfe/trunk/test/Analysis/misc-ps-region-store.m (original)
> +++ cfe/trunk/test/Analysis/misc-ps-region-store.m Tue May 20 12:10:39 2014
> @@ -1362,5 +1362,5 @@ int rdar11125868() {
> int rdar11125868_positive() {
>   int integersStackArray[1];
>   int *integers = integersStackArray;
> -  return integers[0] == 0; // expected-warning {{he left operand of '==' is a}}
> +  return integers[0] == 0; // expected-warning {{the left operand of '==' is a}}
> }
> 
> Modified: cfe/trunk/test/CXX/except/except.spec/p11.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/except/except.spec/p11.cpp?rev=209215&r1=209214&r2=209215&view=diff
> ==============================================================================
> --- cfe/trunk/test/CXX/except/except.spec/p11.cpp (original)
> +++ cfe/trunk/test/CXX/except/except.spec/p11.cpp Tue May 20 12:10:39 2014
> @@ -1,7 +1,7 @@
> // RUN: %clang_cc1 -std=c++11 -fexceptions -fcxx-exceptions -fsyntax-only -verify %s
> // expected-no-diagnostics
> 
> -// This is the "let the user shoot himself in the foot" clause.
> +// This is the "let the user shoot themselves in the foot" clause.
> void f() noexcept {
>   throw 0; // no-error
> }
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list