[PATCH] Rename DynTypedNode to ASTNode

Sean Silva chisophugis at gmail.com
Tue May 20 10:19:36 PDT 2014


Manuel, do you remember why this name was chosen? I seem to recall thinking
that the name was well-chosen.

-- Sean Silva


On Sun, May 18, 2014 at 11:18 PM, Alp Toker <alp at nuanti.com> wrote:

> This is always referred to as an AST node in documentation. By wrapping
> Decls, Stmts and QualTypes it provides a generalised way to reference AST
> nodes. And despite the name, DynTypedNode doesn't have anything to do with
> dynamic types in the AST.
>
> The attached patch renames the class and implementation to ASTNode.
>
> (Indeed the namespace "ast_type_traits" is equally confusing. Presumably
> both are cases where implementation details have leaked into the naming
> scheme?)
>
> Alp.
>
> --
> http://www.nuanti.com
> the browser experts
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140520/092e6385/attachment.html>


More information about the cfe-commits mailing list