r209172 - Get ARCMT/GC-check-warn-nsalloc.m working

Jordan Rose jordan_rose at apple.com
Mon May 19 16:10:07 PDT 2014


> On May 19, 2014, at 15:51, Alp Toker <alp at nuanti.com> wrote:
> 
> -  Diags->setDiagnosticMapping(diag::err_arcmt_nsalloc_realloc,
> -                              NoNSAllocReallocError ? diag::MAP_WARNING
> -                                                    : diag::MAP_ERROR,
> -                              SourceLocation());
> +  if (NoNSAllocReallocError)
> +    Diags->setDiagnosticMapping(diag::warn_arcmt_nsalloc_realloc,
> +                                diag::MAP_IGNORE, SourceLocation());
> 

This changes the behavior of the existing flag from (effectively) -Wno-error= to -Wno-. I don't think we should do that—any existing tools of ours that rely on the frontend flag probably still want the warning, and new tools should just use -W*.

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140519/d9982af4/attachment.html>


More information about the cfe-commits mailing list