[libc++ patch] Don't define __need_FOO in cstddef

[Nico Weber]

Ping.
On May 13, 2014 12:05 PM, "Nico Weber" <thakis at chromium.org> wrote:

> D'oh, forgot to cc Marshall :-)
>
>
> On Tue, May 13, 2014 at 12:00 PM, Nico Weber <thakis at chromium.org> wrote:
>
>> Hi,
>>
>> r207606 changed the __need_foo macros to behave like they do with gcc: If
>> they are set, _only_ the __need_foo stuff gets defined. libc++'s cstddef
>> sets a few __need_foo settings, so cstddef now doesn't work right with
>> libc++ after clang r207606.
>>
>> The attached patch removes the __need_foo defines from libc++'s cstddef.
>> They were added with a cryptic commit message ""for ubuntu" years ago – I
>> think they're incorrect, and things still seem to work without them.
>> (libstdc++ doesn't set them either.) Maybe they were needed before clang
>> had r207606 – if so, this patch should also improve how libc++ works when
>> built with gcc.
>>
>> This fixes PR19723, see the bug for some more information and discussion.
>>
>> Ok?
>>
>> Nico
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140514/77a3fd74/attachment.html>