[PATCH] Clang: Reject OpenCL workgroup size requirement of 0

[David Tweed]

The patch LGTM.
-----Original Message-----
From: cfe-commits-bounces at cs.uiuc.edu
[mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Pedro Ferreira
Sent: 13 May 2014 10:03
To: cfe-commits at cs.uiuc.edu
Subject: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

OpenCL allows us to define the workgroup size used in a kernel in order 
to further optimise the code, specifically to that size.
The syntax is
__attribute__((reqd_work_group_size(X, Y, Z)))

where X, Y and Z are compile-time known integers.
Currently clang allows any of those to be 0, which would be illegal in 
OpenCL.

The attached patch adds this validation; it's currently a draft and any 
comments would be welcome.

(I reported this on bug 19699)