r208497 - Another try at making MSVC happy again.

[Benjamin Kramer]

On 11.05.2014, at 18:38, Alp Toker <alp at nuanti.com> wrote:

> On 11/05/2014 19:03, Benjamin Kramer wrote:
>> Author: d0k
>> Date: Sun May 11 11:03:08 2014
>> New Revision: 208497
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=208497&view=rev
>> Log:
>> Another try at making MSVC happy again.
> 
> What was the MSVC error?
> 
> It doesn't seem appropriate to include DiagnosticOptions.h so widely.

Diagnostics.h is using a IntrusiveRefCntPtr<DiagnosticOptions>. This *should* work with incomplete types when the ctor and dtor are out of line (which is why I removed the include). MSVC seems to think otherwise.

http://bb.pgr.jp/builders/ninja-clang-i686-msc17-R/builds/8491/steps/build_clang_tools/logs/stdio

- Ben

>> 
>> Modified:
>>     cfe/trunk/include/clang/Basic/Diagnostic.h
>> 
>> Modified: cfe/trunk/include/clang/Basic/Diagnostic.h
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Diagnostic.h?rev=208497&r1=208496&r2=208497&view=diff
>> ==============================================================================
>> --- cfe/trunk/include/clang/Basic/Diagnostic.h (original)
>> +++ cfe/trunk/include/clang/Basic/Diagnostic.h Sun May 11 11:03:08 2014
>> @@ -16,6 +16,7 @@
>>  #define LLVM_CLANG_DIAGNOSTIC_H
>>    #include "clang/Basic/DiagnosticIDs.h"
>> +#include "clang/Basic/DiagnosticOptions.h"
>>  #include "clang/Basic/SourceLocation.h"
>>  #include "llvm/ADT/ArrayRef.h"
>>  #include "llvm/ADT/DenseMap.h"
>> @@ -32,7 +33,6 @@ namespace clang {
>>    class DiagnosticOptions;
>>    class IdentifierInfo;
>>    class LangOptions;
>> -  enum OverloadsShown : unsigned;
>>    class Preprocessor;
>>    class StoredDiagnostic;
>>    namespace tok {
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
> -- 
> http://www.nuanti.com
> the browser experts